sascha
/
query
1
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Projects Releases Wiki Activity

fix: comment out unused/invalid code

This commit is contained in:
Sascha Kühl 2026-04-10 16:33:35 +02:00
parent 53ac6810d9
commit f03664d60a
1 changed files with 50 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

100
include/matador/orm/session.hpp
View File

@ -110,56 +110,56 @@ utils::result<object::object_ptr<Type>, utils::error> session::insert(object::ob
} }
// Execute all steps; for Identity steps read RETURNING and write pk back into the object // Execute all steps; for Identity steps read RETURNING and write pk back into the object
for (auto &step : *steps) { // for (auto &step : *steps) {
if (step.pk_is_unset && step.set_pk) { // if (step.pk_is_unset && step.set_pk) {
if (step.pk_generator == utils::generator_type::Manual) { // if (step.pk_generator == utils::generator_type::Manual) {
if (step.pk_is_unset()) { // if (step.pk_is_unset()) {
return utils::failure(make_error(error_code::NoPrimaryKey, "Manual primary key is required but unset.")); // return utils::failure(make_error(error_code::NoPrimaryKey, "Manual primary key is required but unset."));
} // }
} else if (step.pk_generator == utils::generator_type::Sequence) { // } else if (step.pk_generator == utils::generator_type::Sequence) {
if (step.pk_is_unset()) { // if (step.pk_is_unset()) {
// hard-coded naming as you specified earlier // // hard-coded naming as you specified earlier
// <table_name>_seq (table name known in schema meta; if you prefer, store it in step too) // // <table_name>_seq (table name known in schema meta; if you prefer, store it in step too)
// For now, we derive from the schema type used for the root insert: simplistic but works if table name == entity name. // // For now, we derive from the schema type used for the root insert: simplistic but works if table name == entity name.
const std::string seq_name = it->second.name() + "_seq"; // const std::string seq_name = it->second.name() + "_seq";
//
auto id_res = query::select().nextval(seq_name).fetch_value<std::uint64_t>(*this); // auto id_res = query::select().nextval(seq_name).fetch_value<std::uint64_t>(*this);
if (!id_res.is_ok() || !id_res.value().has_value()) { // if (!id_res.is_ok() || !id_res.value().has_value()) {
return utils::failure(make_error(error_code::FailedToBuildQuery, "Failed to obtain next sequence value.")); // return utils::failure(make_error(error_code::FailedToBuildQuery, "Failed to obtain next sequence value."));
} // }
step.set_pk(*id_res.value()); // step.set_pk(*id_res.value());
} // }
} else if (step.pk_generator == utils::generator_type::Table) { // } else if (step.pk_generator == utils::generator_type::Table) {
if (step.pk_is_unset()) { // if (step.pk_is_unset()) {
// TODO: implement table id generation; same idea as above: // // TODO: implement table id generation; same idea as above:
// UPDATE <table>_tbl_seq ... RETURNING ... // // UPDATE <table>_tbl_seq ... RETURNING ...
return utils::failure(make_error(error_code::Failed, "Table primary key generator not implemented yet.")); // return utils::failure(make_error(error_code::Failed, "Table primary key generator not implemented yet."));
} // }
} // }
} // }
//
// --- Execute step --- // // --- Execute step ---
if (std::holds_alternative<query::executable_query>(step.query)) { // if (std::holds_alternative<query::executable_query>(step.query)) {
const auto &q = std::get<query::executable_query>(step.query); // const auto &q = std::get<query::executable_query>(step.query);
const auto exec_res = q.execute(*this); // const auto exec_res = q.execute(*this);
if (!exec_res.is_ok()) { // if (!exec_res.is_ok()) {
return utils::failure(exec_res.err()); // return utils::failure(exec_res.err());
} // }
continue; // continue;
} // }
//
const auto &q = std::get<query::fetchable_query>(step.query); // const auto &q = std::get<query::fetchable_query>(step.query);
auto rec_res = q.fetch_one(*this); // auto rec_res = q.fetch_one(*this);
if (!rec_res.is_ok()) { // if (!rec_res.is_ok()) {
return utils::failure(rec_res.err()); // return utils::failure(rec_res.err());
} // }
if (!rec_res.value().has_value()) { // if (!rec_res.value().has_value()) {
return utils::failure(make_error(error_code::FailedToFindObject, "INSERT ... RETURNING did not return a row.")); // return utils::failure(make_error(error_code::FailedToFindObject, "INSERT ... RETURNING did not return a row."));
} // }
if (step.apply_returning) { // if (step.apply_returning) {
step.apply_returning(*rec_res.value()); // step.apply_returning(*rec_res.value());
} // }
} // }
obj.change_state(object::object_state::Persistent); obj.change_state(object::object_state::Persistent);
return utils::ok(obj); return utils::ok(obj);