fixed linux build for relation completer

include/matador/object/foreign_node_completer.hpp

@@ -44,12 +44,12 @@ public:
     template<class ForeignPointerType>
     void on_belongs_to(const char *id, ForeignPointerType &/*obj*/, const utils::foreign_attributes &/*attr*/);
     template<class ForeignPointerType>
-    static void on_has_one(const char * id, ForeignPointerType &/*obj*/, const utils::foreign_attributes &/*attr*/) {}
+    static void on_has_one(const char * /*id*/, ForeignPointerType &/*obj*/, const utils::foreign_attributes &/*attr*/) {}
 
     template<class CollectionType>
     void on_has_many(const char *id, CollectionType &, const char *join_column, const utils::foreign_attributes &attr, std::enable_if_t<is_object_ptr<typename CollectionType::value_type>::value> * = nullptr);
     template<class CollectionType>
-    void on_has_many(const char *id, CollectionType &, const char *join_column, const utils::foreign_attributes &attr, std::enable_if_t<!is_object_ptr<typename CollectionType::value_type>::value> * = nullptr) {}
+    void on_has_many(const char * /*id*/, CollectionType &, const char * /*join_column*/, const utils::foreign_attributes & /*attr*/, std::enable_if_t<!is_object_ptr<typename CollectionType::value_type>::value> * = nullptr) {}
 
     template<class CollectionType>
     void on_has_many_to_many(const char *id, CollectionType &collection, const char *join_column, const char *inverse_join_column, const utils::foreign_attributes &attr);
@@ -87,22 +87,22 @@ private:
 
 
 template<class ForeignPointerType>
-void foreign_node_completer::on_belongs_to( const char* id, ForeignPointerType&, const utils::foreign_attributes& ) {
+void foreign_node_completer::on_belongs_to( const char* /*id*/, ForeignPointerType&, const utils::foreign_attributes& ) {
     attach_node<typename ForeignPointerType::value_type>();
 }
 
 template<class CollectionType>
-void foreign_node_completer::on_has_many( const char* id, CollectionType&, const char* join_column, const utils::foreign_attributes& attr, std::enable_if_t<is_object_ptr<typename CollectionType::value_type>::value>* ) {
+void foreign_node_completer::on_has_many( const char* /*id*/, CollectionType&, const char* /*join_column*/, const utils::foreign_attributes& /*attr*/, std::enable_if_t<is_object_ptr<typename CollectionType::value_type>::value>* ) {
     attach_node<typename CollectionType::value_type::value_type>();
 }
 
 template<class CollectionType>
-void foreign_node_completer::on_has_many_to_many( const char* id, CollectionType& collection, const char* join_column, const char* inverse_join_column, const utils::foreign_attributes& attr ) {
+void foreign_node_completer::on_has_many_to_many( const char* /*id*/, CollectionType& /*collection*/, const char* /*join_column*/, const char* /*inverse_join_column*/, const utils::foreign_attributes& /*attr*/ ) {
     attach_node<typename CollectionType::value_type::value_type>();
 }
 
 template<class CollectionType>
-void foreign_node_completer::on_has_many_to_many( const char* id, CollectionType& collection, const utils::foreign_attributes& attr ) {
+void foreign_node_completer::on_has_many_to_many( const char* /*id*/, CollectionType& /*collection*/, const utils::foreign_attributes& /*attr*/ ) {
     attach_node<typename CollectionType::value_type::value_type>();
 }
 

include/matador/object/internal/shadow_schema.hpp

@@ -20,8 +20,8 @@ private:
 public:
   explicit shadow_schema(object::schema& s);
 
-  schema& schema() const;
-  bool schema_contains(const std::type_index& ti) const;
+  object::schema& schema() const;
+  [[nodiscard]] bool schema_contains(const std::type_index& ti) const;
   [[nodiscard]] utils::result<node_ptr, utils::error> find_node(const std::type_index &type_index) const;
   [[nodiscard]] utils::result<node_ptr, utils::error> attach_node(const std::shared_ptr<schema_node> &node) const;
   [[nodiscard]] utils::result<void, utils::error> detach_node(const std::shared_ptr<schema_node> &node) const;

include/matador/sql/connection_pool.hpp

@@ -82,7 +82,10 @@ public:
       auto &conn = connection_repo_.back();
       idle_connections_.emplace(conn.first, &conn);
       // Todo: handle result
-      std::ignore = conn.second.open();
+      const auto result = conn.second.open();
+      if (!result) {
+        throw std::runtime_error("Failed to open connection");
+      }
       --count;
     }
   }

include/matador/utils/primary_key_attribute.hpp

@@ -1,11 +1,13 @@
 #ifndef PRIMARY_KEY_ATTRIBUTE_HPP
 #define PRIMARY_KEY_ATTRIBUTE_HPP
 
+#include <cstddef>
+
 namespace matador::utils {
 class primary_key_attribute final {
 public:
     /**
-     * Creates primary_key_attribute instance
+     * Creates a primary_key_attribute instance
      * with size 0 (zero).
      */
     primary_key_attribute() = default;